regulator: qcom_spmi: Always return a selector when asked
authorStephen Boyd <sboyd@codeaurora.org>
Fri, 15 Apr 2016 17:44:37 +0000 (10:44 -0700)
committerMark Brown <broonie@kernel.org>
Mon, 18 Apr 2016 10:05:11 +0000 (11:05 +0100)
I had a thinko in spmi_regulator_select_voltage_same_range() when
converting it to return selectors via the function's return value
instead of by modifying a pointer argument. I only tested
multi-range regulators so this passed through testing. Fix it by
returning the selector here.

Fixes: 1b5b19689278 ("regulator: qcom_spmi: Only use selector based regulator ops")
Reported-by: Rajendra Nayak <rnayak@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/qcom_spmi-regulator.c

index f502f2c..84cce21 100644 (file)
@@ -692,7 +692,7 @@ static int spmi_regulator_select_voltage_same_range(struct spmi_regulator *vreg,
        if (selector >= vreg->set_points->n_voltages)
                goto different_range;
 
-       return 0;
+       return selector;
 
 different_range:
        return spmi_regulator_select_voltage(vreg, min_uV, max_uV);