gcc-9: don't warn about uninitialized variable 92/221392/1
authorLinus Torvalds <torvalds@linux-foundation.org>
Wed, 1 May 2019 18:07:40 +0000 (11:07 -0700)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Tue, 31 Dec 2019 04:50:58 +0000 (13:50 +0900)
commit cf676908846a06443fa5e6724ca3f5dd7460eca1 upstream.

I'm not sure what made gcc warn about this code now.  The 'ret' variable
does end up initialized in all cases, but it's definitely not obvious,
so the compiler is quite reasonable to warn about this.

So just add initialization to make it all much more obvious both to
compilers and to humans.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[sw0312.kim: cherry-pick from stable linux-4.19.y commit a152a7b411a5 for gcc 9 build]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: I9ffd18114904d32ebb631680c7ac40d9771771c2

drivers/i2c/i2c-core-base.c

index 5b0e1d9e5adc053c2831397f8dfd2128bc89d777..1de10e5c70d7b661809bf20a02f4d8d057b02d1e 100644 (file)
@@ -185,7 +185,7 @@ static int i2c_generic_bus_free(struct i2c_adapter *adap)
 int i2c_generic_scl_recovery(struct i2c_adapter *adap)
 {
        struct i2c_bus_recovery_info *bri = adap->bus_recovery_info;
-       int i = 0, scl = 1, ret;
+       int i = 0, scl = 1, ret = 0;
 
        if (bri->prepare_recovery)
                bri->prepare_recovery(adap);