Remove Profile Build Dependency (trivial) 50/97350/3 accepted/tizen/3.0/common/20170131.161746 accepted/tizen/3.0/ivi/20170131.090415 accepted/tizen/3.0/mobile/20170131.090322 accepted/tizen/3.0/tv/20170131.090347 accepted/tizen/3.0/wearable/20170131.090401 submit/tizen_3.0/20170131.015755
authorMyungJoo Ham <myungjoo.ham@samsung.com>
Mon, 14 Nov 2016 02:40:46 +0000 (11:40 +0900)
committerjongmyeong ko <jongmyeong.ko@samsung.com>
Thu, 5 Jan 2017 08:19:37 +0000 (00:19 -0800)
- This is for Tizen 4.0

  : Tizen 4.0 Configurability and Build Blocks require
  to remove all profile-depending build options in spec files.
  (No More profile macros)

- The profile macro that creates TIZEN_* definition in the code is useless
because no one is using it:

manifest-parser$ grep -r "TIZEN_" *
CMakeLists.txt:ADD_DEFINITIONS("-DTIZEN_VERSION=\"${TIZEN_VERSION}\"")
CMakeLists.txt:IF(TIZEN_PROFILE STREQUAL "tv")
CMakeLists.txt:  ADD_DEFINITIONS("-DTIZEN_TV")
CMakeLists.txt:ELSEIF(TIZEN_PROFILE STREQUAL "mobile")
CMakeLists.txt:  ADD_DEFINITIONS("-DTIZEN_MOBILE")
CMakeLists.txt:ELSEIF(TIZEN_PROFILE STREQUAL "wearable")
CMakeLists.txt:  ADD_DEFINITIONS("-DTIZEN_WEARABLE")
packaging/manifest-parser.spec:         -DTIZEN_VERSION=%{tizen_version} \
packaging/manifest-parser.spec:         -DTIZEN_PROFILE=%{profile}
manifest-parser$

Change-Id: I560c08a864e9a3c2b8e9c96c5b01fe871b505dcf
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
CMakeLists.txt
packaging/manifest-parser.spec

index 10b872820a6d67d981bfb7cb46bf2ee438d1dfdc..312d9826ec8b6068a0cd3d36cc509b0ad996bf26 100644 (file)
@@ -37,13 +37,6 @@ ADD_DEFINITIONS("-DPROJECT_TAG=\"MANIFEST_PARSER\"")
 
 ADD_DEFINITIONS("-DSHAREDIR=\"${SHAREDIR}\"")
 ADD_DEFINITIONS("-DTIZEN_VERSION=\"${TIZEN_VERSION}\"")
-IF(TIZEN_PROFILE STREQUAL "tv")
-  ADD_DEFINITIONS("-DTIZEN_TV")
-ELSEIF(TIZEN_PROFILE STREQUAL "mobile")
-  ADD_DEFINITIONS("-DTIZEN_MOBILE")
-ELSEIF(TIZEN_PROFILE STREQUAL "wearable")
-  ADD_DEFINITIONS("-DTIZEN_WEARABLE")
-ENDIF()
 
 SET(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_CURRENT_SOURCE_DIR}/cmake/Modules/")
 INCLUDE(FindPkgConfig)
index a5843b5123ce7f3526606bd1fe0d9fe677f945fa..b9a7e2a3e60f0db43939cd33db77f0118e742fad 100644 (file)
@@ -61,8 +61,7 @@ export FFLAGS="$(echo $FFLAGS | sed 's/-Wl,--as-needed//g')"
 # is used in CMakeLists.txt files to distinguish, which project
 # is currently being build.
 %cmake . -DCMAKE_BUILD_TYPE=%{?build_type:%build_type} \
-         -DTIZEN_VERSION=%{tizen_version} \
-         -DTIZEN_PROFILE=%{profile}
+         -DTIZEN_VERSION=%{tizen_version}
 
 make %{?_smp_mflags}