lib: sbi_hsm: Move misplaced comment
authorAndrew Jones <ajones@ventanamicro.com>
Mon, 27 Feb 2023 10:30:59 +0000 (11:30 +0100)
committerAnup Patel <anup@brainfault.org>
Mon, 27 Feb 2023 14:08:00 +0000 (19:38 +0530)
While non-retentive suspend is not allowed for M-mode, the comment
at the top of sbi_hsm_hart_suspend() implied suspend wasn't allowed
for M-mode at all. Move the comment above the mode check which is
inside a suspend type is non-retentive check.

Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
lib/sbi/sbi_hsm.c

index 3455520..294156a 100644 (file)
@@ -398,8 +398,6 @@ int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type,
        struct sbi_hsm_data *hdata = sbi_scratch_offset_ptr(scratch,
                                                            hart_data_offset);
 
-       /* For now, we only allow suspend from S-mode or U-mode. */
-
        /* Sanity check on domain assigned to current HART */
        if (!dom)
                return SBI_EFAIL;
@@ -414,6 +412,10 @@ int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type,
 
        /* Additional sanity check for non-retentive suspend */
        if (suspend_type & SBI_HSM_SUSP_NON_RET_BIT) {
+               /*
+                * For now, we only allow non-retentive suspend from
+                * S-mode or U-mode.
+                */
                if (rmode != PRV_S && rmode != PRV_U)
                        return SBI_EFAIL;
                if (dom && !sbi_domain_check_addr(dom, raddr, rmode,