c++: Reject union std::initializer_list [PR102434]
authorMarek Polacek <polacek@redhat.com>
Sat, 29 Jan 2022 01:01:06 +0000 (20:01 -0500)
committerMarek Polacek <polacek@redhat.com>
Mon, 31 Jan 2022 20:35:20 +0000 (15:35 -0500)
Weird things are going to happen if you define your std::initializer_list
as a union.  In this case, we crash in output_constructor_regular_field.

Let's not allow such a definition in the first place.

PR c++/102434

gcc/cp/ChangeLog:

* class.cc (finish_struct): Don't allow union initializer_list.

gcc/testsuite/ChangeLog:

* g++.dg/cpp0x/initlist128.C: New test.

gcc/cp/class.cc
gcc/testsuite/g++.dg/cpp0x/initlist128.C [new file with mode: 0644]

index 5db3722..6961557 100644 (file)
@@ -7766,6 +7766,8 @@ finish_struct (tree t, tree attributes)
                ok = true;
            }
        }
+      /* It also cannot be a union.  */
+      ok &= NON_UNION_CLASS_TYPE_P (t);
       if (!ok)
        fatal_error (input_location, "definition of %qD does not match "
                     "%<#include <initializer_list>%>", TYPE_NAME (t));
diff --git a/gcc/testsuite/g++.dg/cpp0x/initlist128.C b/gcc/testsuite/g++.dg/cpp0x/initlist128.C
new file mode 100644 (file)
index 0000000..2224686
--- /dev/null
@@ -0,0 +1,16 @@
+// PR c++/102434
+// { dg-do compile { target c++11 } }
+
+using size_t = decltype(sizeof 0);
+
+namespace std {
+  template<typename T> union initializer_list { // { dg-error "definition of .*std::initializer_list.* does not match" }
+    const T *ptr;
+    size_t n;
+  };
+}
+template<typename T>
+void Task() {}
+auto b = { &Task<int> };
+
+// { dg-prune-output "compilation terminated" }