spi: spi-au1550: replace ternary operator with min()
authorGuo Zhengkui <guozhengkui@vivo.com>
Fri, 13 May 2022 13:03:33 +0000 (21:03 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 16 May 2022 16:57:01 +0000 (17:57 +0100)
Fix the following coccicheck warnings:

drivers/spi/spi-au1550.c:408:21-22: WARNING opportunity for min()
drivers/spi/spi-au1550.c:542:21-22: WARNING opportunity for min()

min() macro is defined in include/linux/minmax.h. It avoids multiple
evaluations of the arguments when non-constant and performs strict
type-checking.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Link: https://lore.kernel.org/r/20220513130333.58379-1-guozhengkui@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-au1550.c

index 4b59a1b..e008761 100644 (file)
@@ -405,7 +405,7 @@ static int au1550_spi_dma_txrxb(struct spi_device *spi, struct spi_transfer *t)
                dma_unmap_single(hw->dev, dma_tx_addr, t->len,
                        DMA_TO_DEVICE);
 
-       return hw->rx_count < hw->tx_count ? hw->rx_count : hw->tx_count;
+       return min(hw->rx_count, hw->tx_count);
 }
 
 static irqreturn_t au1550_spi_dma_irq_callback(struct au1550_spi *hw)
@@ -539,7 +539,7 @@ static int au1550_spi_pio_txrxb(struct spi_device *spi, struct spi_transfer *t)
 
        wait_for_completion(&hw->master_done);
 
-       return hw->rx_count < hw->tx_count ? hw->rx_count : hw->tx_count;
+       return min(hw->rx_count, hw->tx_count);
 }
 
 static irqreturn_t au1550_spi_pio_irq_callback(struct au1550_spi *hw)