net: ipa: synchronize NAPI only for suspend

When stopping a channel, gsi_channel_stop() will ensure NAPI
polling is complete when it calls napi_disable().  So there is no
need to call napi_synchronize() in that case.

Move the call to napi_synchronize() out of __gsi_channel_stop()
and into gsi_channel_suspend(), so it's only used where needed.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index f0432c965168cf9b443317a7c5ac8df4bd8864ec..60eb765c5364792a6a9b62129d15a4dfa9d48d65 100644 (file)
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -939,13 +939,7 @@ static int __gsi_channel_stop(struct gsi_channel *channel, bool stop)
 
        mutex_unlock(&gsi->mutex);
 
-       if (ret)
-               return ret;
-
-       /* Ensure NAPI polling has finished. */
-       napi_synchronize(&channel->napi);
-
-       return 0;
+       return ret;
 }
 
 /* Stop a started channel */
@@ -987,8 +981,16 @@ void gsi_channel_reset(struct gsi *gsi, u32 channel_id, bool doorbell)
 int gsi_channel_suspend(struct gsi *gsi, u32 channel_id, bool stop)
 {
        struct gsi_channel *channel = &gsi->channel[channel_id];
+       int ret;
+
+       ret = __gsi_channel_stop(channel, stop);
+       if (ret)
+               return ret;
 
-       return __gsi_channel_stop(channel, stop);
+       /* Ensure NAPI polling has finished. */
+       napi_synchronize(&channel->napi);
+
+       return 0;
 }
 
 /* Resume a suspended channel (starting will be requested if STOPPED) */