soundwire: cadence: commit changes in the exit_reset() sequence
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 17 Mar 2020 16:33:27 +0000 (11:33 -0500)
committerVinod Koul <vkoul@kernel.org>
Thu, 19 Mar 2020 07:13:04 +0000 (12:43 +0530)
Follow recommended flows, the BUS_RESET must be programmed before the
UPDATE_CONFIG.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200317163329.25501-16-pierre-louis.bossart@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c

index c9fdd4d..55cf219 100644 (file)
@@ -1074,7 +1074,6 @@ static void cdns_init_clock_ctrl(struct sdw_cdns *cdns)
 int sdw_cdns_init(struct sdw_cdns *cdns)
 {
        u32 val;
-       int ret;
 
        cdns_init_clock_ctrl(cdns);
 
@@ -1113,8 +1112,8 @@ int sdw_cdns_init(struct sdw_cdns *cdns)
 
        cdns_writel(cdns, CDNS_MCP_CONFIG, val);
 
-       /* commit changes */
-       return cdns_config_update(cdns);
+       /* changes will be committed later */
+       return 0;
 }
 EXPORT_SYMBOL(sdw_cdns_init);