projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3c431e1
)
HID: potential dereference of null pointer
author
Jiasheng Jiang
<jiasheng@iscas.ac.cn>
Wed, 15 Dec 2021 08:36:05 +0000
(16:36 +0800)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 29 Dec 2021 11:28:37 +0000
(12:28 +0100)
commit
13251ce1dd9bb525da2becb9b26fdfb94ca58659
upstream.
The return value of devm_kzalloc() needs to be checked.
To avoid hdev->dev->driver_data to be null in case of the failure of
alloc.
Fixes:
14c9c014babe
("HID: add vivaldi HID driver")
Cc: stable@vger.kernel.org
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Link:
https://lore.kernel.org/r/20211215083605.117638-1-jiasheng@iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-vivaldi.c
patch
|
blob
|
history
diff --git
a/drivers/hid/hid-vivaldi.c
b/drivers/hid/hid-vivaldi.c
index
cd7ada4
..
72957a9
100644
(file)
--- a/
drivers/hid/hid-vivaldi.c
+++ b/
drivers/hid/hid-vivaldi.c
@@
-57,6
+57,9
@@
static int vivaldi_probe(struct hid_device *hdev,
int ret;
drvdata = devm_kzalloc(&hdev->dev, sizeof(*drvdata), GFP_KERNEL);
+ if (!drvdata)
+ return -ENOMEM;
+
hid_set_drvdata(hdev, drvdata);
ret = hid_parse(hdev);