projects
/
platform
/
upstream
/
kernel-adaptation-pc.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9ef28cc
)
firewire: ohci: add a comment on PHY reg access serialization
author
Stefan Richter
<stefanr@s5r6.in-berlin.de>
Tue, 21 Jun 2011 13:24:26 +0000
(15:24 +0200)
committer
Stefan Richter
<stefanr@s5r6.in-berlin.de>
Sat, 9 Jul 2011 15:12:08 +0000
(17:12 +0200)
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/ohci.c
patch
|
blob
|
history
diff --git
a/drivers/firewire/ohci.c
b/drivers/firewire/ohci.c
index
3b6f342
..
a818dc8
100644
(file)
--- a/
drivers/firewire/ohci.c
+++ b/
drivers/firewire/ohci.c
@@
-513,6
+513,12
@@
static inline void flush_writes(const struct fw_ohci *ohci)
reg_read(ohci, OHCI1394_Version);
}
+/*
+ * Beware! read_phy_reg(), write_phy_reg(), update_phy_reg(), and
+ * read_paged_phy_reg() require the caller to hold ohci->phy_reg_mutex.
+ * In other words, only use ohci_read_phy_reg() and ohci_update_phy_reg()
+ * directly. Exceptions are intrinsically serialized contexts like pci_probe.
+ */
static int read_phy_reg(struct fw_ohci *ohci, int addr)
{
u32 val;