qnx4_lookup: use d_splice_alias()
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 1 May 2018 00:02:31 +0000 (20:02 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Tue, 22 May 2018 18:27:52 +0000 (14:27 -0400)
code is simpler that way

Acked-by: Anders Larsen <al@alarsen.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/qnx4/namei.c

index eca2787..8d72221 100644 (file)
@@ -114,13 +114,9 @@ struct dentry * qnx4_lookup(struct inode *dir, struct dentry *dentry, unsigned i
        brelse(bh);
 
        foundinode = qnx4_iget(dir->i_sb, ino);
-       if (IS_ERR(foundinode)) {
+       if (IS_ERR(foundinode))
                QNX4DEBUG((KERN_ERR "qnx4: lookup->iget -> error %ld\n",
                           PTR_ERR(foundinode)));
-               return ERR_CAST(foundinode);
-       }
 out:
-       d_add(dentry, foundinode);
-
-       return NULL;
+       return d_splice_alias(foundinode, dentry);
 }