sfc: nicer log message on PTP probe fail
authorEdward Cree <ecree@solarflare.com>
Tue, 12 May 2015 12:04:52 +0000 (13:04 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 May 2015 19:11:51 +0000 (15:11 -0400)
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ptp.c

index a2e9aee..8c5c96a 100644 (file)
@@ -604,7 +604,12 @@ static int efx_ptp_disable(struct efx_nic *efx)
        rc = efx_mcdi_rpc_quiet(efx, MC_CMD_PTP, inbuf, sizeof(inbuf),
                                outbuf, sizeof(outbuf), NULL);
        rc = (rc == -EALREADY) ? 0 : rc;
-       if (rc)
+       /* If we get ENOSYS, the NIC doesn't support PTP, and thus this function
+        * should only have been called during probe.
+        */
+       if (rc == -ENOSYS || rc == -EPERM)
+               netif_info(efx, probe, efx->net_dev, "no PTP support\n");
+       else if (rc)
                efx_mcdi_display_error(efx, MC_CMD_PTP,
                                       MC_CMD_PTP_IN_DISABLE_LEN,
                                       outbuf, sizeof(outbuf), rc);