projects
/
platform
/
kernel
/
u-boot.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4708a07
)
mkimage: Close the file when unable to get its size
author
Simon Glass
<sjg@chromium.org>
Wed, 16 Mar 2016 13:45:37 +0000
(07:45 -0600)
committer
Tom Rini
<trini@konsulko.com>
Tue, 22 Mar 2016 16:16:19 +0000
(12:16 -0400)
There is a missing close() on the error path. Add it.
Reported-by: Coverity (CID: 138496)
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Tom Rini <trini@konsulko.com>
tools/imagetool.c
patch
|
blob
|
history
diff --git
a/tools/imagetool.c
b/tools/imagetool.c
index
351211c
..
916ab96
100644
(file)
--- a/
tools/imagetool.c
+++ b/
tools/imagetool.c
@@
-107,6
+107,7
@@
int imagetool_get_filesize(struct image_tool_params *params, const char *fname)
if (fstat(fd, &sbuf) < 0) {
fprintf(stderr, "%s: Can't stat %s: %s\n",
params->cmdname, fname, strerror(errno));
+ close(fd);
return -1;
}
close(fd);