media: exynos4-is: Correct missing entity function initialization
authorJonathan Bakker <xc-racer2@live.ca>
Thu, 30 Jul 2020 23:01:07 +0000 (01:01 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 1 Sep 2020 12:13:25 +0000 (14:13 +0200)
Commit bae4500399c4 ("[media] exynos4-is: Add missing entity function
initialization") tried to suppress the warnings such as

s5p-fimc-md camera: Entity type for entity FIMC.0 was not initialized!

However, this missed setting for the subdev.  Set it now to avoid the
ugly warnings on boot.

Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/exynos4-is/fimc-capture.c

index 4fbf550..73b632e 100644 (file)
@@ -1888,6 +1888,7 @@ int fimc_initialize_capture_subdev(struct fimc_dev *fimc)
                return ret;
 
        sd->entity.ops = &fimc_sd_media_ops;
+       sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_SCALER;
        sd->internal_ops = &fimc_capture_sd_internal_ops;
        v4l2_set_subdevdata(sd, fimc);
        return 0;