phy: rockchip-inno-usb2: Prevent incorrect error on probe
authorPeter Geis <pgwipeout@gmail.com>
Sat, 25 Jun 2022 21:27:11 +0000 (17:27 -0400)
committerVinod Koul <vkoul@kernel.org>
Tue, 5 Jul 2022 06:33:21 +0000 (12:03 +0530)
If a phy supply is designated but isn't available at probe time, an
EPROBE_DEFER is returned. Use dev_err_probe to prevent this from
incorrectly printing during boot.

Signed-off-by: Peter Geis <pgwipeout@gmail.com>
Link: https://lore.kernel.org/r/20220625212711.558495-1-pgwipeout@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c

index 6711659f727c1c8ffdba1063214bc299ec51d00c..04fc1462d0f0df52e2a54ed169269bffda3519eb 100644 (file)
@@ -1283,7 +1283,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev)
 
                phy = devm_phy_create(dev, child_np, &rockchip_usb2phy_ops);
                if (IS_ERR(phy)) {
-                       dev_err(dev, "failed to create phy\n");
+                       dev_err_probe(dev, PTR_ERR(phy), "failed to create phy\n");
                        ret = PTR_ERR(phy);
                        goto put_child;
                }