hwrng: omap - Delete an error message in of_get_omap_rng_device_details()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 4 Apr 2020 14:45:57 +0000 (16:45 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 16 Apr 2020 06:49:22 +0000 (16:49 +1000)
The function “platform_get_irq” can log an error already.
Thus omit a redundant message for the exception handling in the
calling function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/omap-rng.c

index 6595239..7290c60 100644 (file)
@@ -392,11 +392,8 @@ static int of_get_omap_rng_device_details(struct omap_rng_dev *priv,
        if (of_device_is_compatible(dev->of_node, "ti,omap4-rng") ||
            of_device_is_compatible(dev->of_node, "inside-secure,safexcel-eip76")) {
                irq = platform_get_irq(pdev, 0);
-               if (irq < 0) {
-                       dev_err(dev, "%s: error getting IRQ resource - %d\n",
-                               __func__, irq);
+               if (irq < 0)
                        return irq;
-               }
 
                err = devm_request_irq(dev, irq, omap4_rng_irq,
                                       IRQF_TRIGGER_NONE, dev_name(dev), priv);