Fixes from codereview

  * Sets plugin provider name as capital letters
  * removes tabs
  * removes temporary files not used in project
  * changes build flag from c++11 -> c++0x

Change-Id: I9fb2154213b8ae88300e783e198ed919d7425647

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2726d0f..bdc6ed3 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -22,7 +22,7 @@ SET(PREFIX ${CMAKE_INSTALL_PREFIX})
 
 SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_CFLAGS} -fvisibility=hidden -fPIC -Wall -Werror")
 SET(CMAKE_C_FLAGS_DEBUG "-O0 -g")
-SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fpie ${EXTRA_CFLAGS} -Wall -g -fPIC -std=c++11 -fvisibility=hidden")
+SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fpie ${EXTRA_CFLAGS} -Wall -g -fPIC -std=c++0x -fvisibility=hidden")
 
 IF("${ARCH}" STREQUAL "arm")
     ADD_DEFINITIONS("-DTARGET")

diff --git a/circle.yml b/circle.yml
deleted file mode 100644 (file)
index 6546b17..0000000
--- a/circle.yml
+++ /dev/null
@@ -1,22 +0,0 @@
-dependencies:
-  pre:
-    - sudo cp conf/tizen.list /etc/apt/sources.list.d/
-    - sudo apt-get update
-    - sudo apt-get install gbs
-    - cp conf/gbs.conf ~/.gbs.conf
-
-test:
-  override:
-    - echo "nothing to see here"
-
-general:
-  artifacts:
-    - "~/GBS-ROOT_arm"
-    - "~/GBS-ROOT_i586"
-
-deployment:
-  development:
-    branch: master
-    commands:
-      - gbs build --include-all -A armv7l --profile profile.tizen_3.0_mobile_z3 --buildroot ~/GBS-ROOT_arm
-      - gbs build --include-all -A i586 --profile profile.tizen_3.0_emulator32 --buildroot ~/GBS-ROOT_i586

diff --git a/conf/gbs.conf b/conf/gbs.conf
deleted file mode 100644 (file)
index 1fe0846..0000000
--- a/conf/gbs.conf
+++ /dev/null
@@ -1,64 +0,0 @@
-[general]
-#profile = profile.tizen_3.0_mobile_z3
-#profile = profile.tizen_3.0_mobile_aarch64            #64bit OS is required.
-#profile = profile.tizen_3.0_emulator32
-#profile = profile.tizen_3.0_emulator64                        #64bit OS is required.
-#profile = profile.tizen_3.0_mobile_wearable
-
-[profile.tizen_3.0_mobile_z3]
-obs = obs.tizen
-repos = repo.public_3.0_base_arm, repo.public_3.0_mobile_z3
-
-[profile.tizen_3.0_mobile_wearable]
-obs = obs.tizen
-repos = repo.public_3.0_base_arm, repo.public_3.0_mobile_wearable
-
-[profile.tizen_3.0_mobile_aarch64]
-obs = obs.tizen
-repos = repo.public_3.0_base_aarch64, repo.public_3.0_mobile_aarch64
-
-[profile.tizen_3.0_emulator32]
-obs = obs.tizen
-repos = repo.public_3.0_base_emulator32, repo.public_3.0_mobile_emulator32
-buildroot = ~/GBS-ROOT_emulator32
-
-[profile.tizen_3.0_emulator64]
-obs = obs.tizen
-repos = repo.public_3.0_base_emulator64, repo.public_3.0_mobile_emulator64
-
-
-[obs.tizen]
-url = https://api.tizen.org
-user = obs_viewer
-passwdx = QlpoOTFBWSZTWWV18UwAAAKDgAAAkiCZgCAAMQZMQQDJ6jQwAvxdyRThQkGV18Uw
-
-[repo.public_3.0_base_arm]
-url = http://download.tizen.org/snapshots/tizen/base/latest/repos/arm/packages/
-
-[repo.public_3.0_base_aarch64]
-url = http://download.tizen.org/snapshots/tizen/base/latest/repos/arm64/packages/
-
-[repo.public_3.0_base_emulator32]
-url = http://download.tizen.org/snapshots/tizen/base/latest/repos/emulator32/packages/
-
-[repo.public_3.0_mobile_emulator64]
-url = http://download.tizen.org/snapshots/tizen/base/latest/repos/emulator64/packages/
-
-
-
-[repo.public_3.0_mobile_z3]
-url = http://download.tizen.org/snapshots/tizen/mobile/latest/repos/target-TM1/packages/
-
-[repo.public_3.0_mobile_wearable]
-url = http://download.tizen.org/snapshots/tizen/wearable/latest/repos/target-circle/packages/
-
-[repo.public_3.0_mobile_aarch64]
-url = http://download.tizen.org/snapshots/tizen/mobile/latest/repos/arm64-wayland/packages/
-
-[repo.public_3.0_mobile_emulator32]
-url = http://download.tizen.org/snapshots/tizen/mobile/latest/repos/emulator32-wayland/packages/
-
-[repo.public_3.0_mobile_emulator64]
-url = http://download.tizen.org/snapshots/tizen/mobile/latest/repos/emulator64-wayland/packages/
-
-

diff --git a/conf/tizen.list b/conf/tizen.list
deleted file mode 100644 (file)
index 7e6b8a6..0000000
--- a/conf/tizen.list
+++ /dev/null
@@ -1,2 +0,0 @@
-deb http://download.tizen.org/tools/latest-release/Ubuntu_14.04 /
-

diff --git a/maps-plugin-mapzen.changes b/maps-plugin-mapzen.changes
index 7c3efb9..21b2937 100644 (file)
--- a/maps-plugin-mapzen.changes
+++ b/maps-plugin-mapzen.changes
@@ -1,4 +1,4 @@
 [Version]   maps-plugin-mapzen_0.0.1
 [Date]      27 May 2016
 [Title]     Initialize version
-[Developer] Baldur <baldur@mapzen.com> 
+[Developer] Baldur <baldur@mapzen.com>

diff --git a/src/mapzen_plugin.c b/src/mapzen_plugin.c
index 4184ea5..069b525 100644 (file)
--- a/src/mapzen_plugin.c
+++ b/src/mapzen_plugin.c
@@ -280,7 +280,7 @@ EXPORT_API int maps_plugin_get_info(maps_plugin_info_h *info)
                return MAPS_ERROR_INVALID_PARAMETER;
 
        maps_plugin_info_create(info);
-       maps_plugin_info_set_provider_name(*info, "mapzen");
+       maps_plugin_info_set_provider_name(*info, "MAPZEN");
 
        return MAPS_ERROR_NONE;
 }
@@ -881,7 +881,7 @@ EXPORT_API int maps_plugin_search_route(const maps_coordinates_h origin, const m
                route_req->unit = UNIT_M; //miles, not meters
                break;
        case MAPS_DISTANCE_UNIT_KM:
-               route_req->unit =       UNIT_KM;
+               route_req->unit = UNIT_KM;
                break;
        case MAPS_DISTANCE_UNIT_FT:
                //route_req->unit = ROUTE_UNIT_FT;
@@ -906,7 +906,7 @@ EXPORT_API int maps_plugin_search_route(const maps_coordinates_h origin, const m
                else if ((routeFeature == MAPS_ROUTE_FEATURE_BOATFERRY) || (routeFeature == MAPS_ROUTE_FEATURE_RAILFERRY))
                        route_req->avoids = PENALTY_USE_FERRY;
                else if (routeFeature == MAPS_ROUTE_FEATURE_DIRTROAD)
-                       route_req->avoids =     PENALTY_USE_UNPAVED;
+                       route_req->avoids = PENALTY_USE_UNPAVED;
                else
                        route_req->avoids = PENALTY_NONE;
        }