staging: gasket: page table: return valid error code on map fail
authorTodd Poynor <toddpoynor@google.com>
Mon, 15 Oct 2018 04:59:18 +0000 (21:59 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 Oct 2018 14:30:37 +0000 (16:30 +0200)
Return -EINVAL on mapping failures, instead of -1, which triggers a
checkpatch error.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_page_table.c

index 964146f..2e1de8a 100644 (file)
@@ -514,13 +514,12 @@ static int gasket_perform_mapping(struct gasket_page_table *pg_tbl,
                                        (void *)page_to_pfn(page),
                                        (void *)page_to_phys(page));
 
-                               /* clean up */
                                if (gasket_release_page(ptes[i].page))
                                        --pg_tbl->num_active_pages;
 
                                memset(&ptes[i], 0,
                                       sizeof(struct gasket_page_table_entry));
-                               return -1;
+                               return -EINVAL;
                        }
                }
 
@@ -1165,7 +1164,7 @@ fail:
        *ppage = NULL;
        *poffset = 0;
        mutex_unlock(&pg_tbl->mutex);
-       return -1;
+       return -EINVAL;
 }
 
 /* See gasket_page_table.h for description. */