RDMA/rxe: Removed unused name from rxe_task struct

[ Upstream commit de669ae8af49ceed0eed44f5b3d51dc62affc5e4 ]

The name field in struct rxe_task is never used. This patch removes it.

Link: https://lore.kernel.org/r/20221021200118.2163-4-rpearsonhpe@gmail.com
Signed-off-by: Ian Ziemba <ian.ziemba@hpe.com>
Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Stable-dep-of: 2a62b6210ce8 ("RDMA/rxe: Fix the use-before-initialization error of resp_pkts")
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c
index 1f6e006c51c4aee1a3f1c1ad139052f1dce2d757..f48a624de493d17aea4ad2a768a6a5e5a408745d 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_qp.c
+++ b/drivers/infiniband/sw/rxe/rxe_qp.c
@@ -242,10 +242,8 @@ static int rxe_qp_init_req(struct rxe_dev *rxe, struct rxe_qp *qp,
 
        skb_queue_head_init(&qp->req_pkts);
 
-       rxe_init_task(&qp->req.task, qp,
-                     rxe_requester, "req");
-       rxe_init_task(&qp->comp.task, qp,
-                     rxe_completer, "comp");
+       rxe_init_task(&qp->req.task, qp, rxe_requester);
+       rxe_init_task(&qp->comp.task, qp, rxe_completer);
 
        qp->qp_timeout_jiffies = 0; /* Can't be set for UD/UC in modify_qp */
        if (init->qp_type == IB_QPT_RC) {
@@ -292,8 +290,7 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp,
 
        skb_queue_head_init(&qp->resp_pkts);
 
-       rxe_init_task(&qp->resp.task, qp,
-                     rxe_responder, "resp");
+       rxe_init_task(&qp->resp.task, qp, rxe_responder);
 
        qp->resp.opcode         = OPCODE_NONE;
        qp->resp.msn            = 0;

diff --git a/drivers/infiniband/sw/rxe/rxe_task.c b/drivers/infiniband/sw/rxe/rxe_task.c
index ec2b7de1c4972105e1552b2bf3c8190869ce86a8..182d0532a8ab9b426870dc879a19b1eb0df6aac9 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_task.c
+++ b/drivers/infiniband/sw/rxe/rxe_task.c
@@ -94,12 +94,10 @@ void rxe_do_task(struct tasklet_struct *t)
        task->ret = ret;
 }
 
-int rxe_init_task(struct rxe_task *task,
-                 void *arg, int (*func)(void *), char *name)
+int rxe_init_task(struct rxe_task *task, void *arg, int (*func)(void *))
 {
        task->arg       = arg;
        task->func      = func;
-       snprintf(task->name, sizeof(task->name), "%s", name);
        task->destroyed = false;
 
        tasklet_setup(&task->tasklet, rxe_do_task);

diff --git a/drivers/infiniband/sw/rxe/rxe_task.h b/drivers/infiniband/sw/rxe/rxe_task.h
index 7f612a1c68a7ba3c76d02aaa1fd5ee04c384a2bd..b3dfd970d1dc6b2d558d594e684364fc849cb9a0 100644 (file)
--- a/drivers/infiniband/sw/rxe/rxe_task.h
+++ b/drivers/infiniband/sw/rxe/rxe_task.h
@@ -25,7 +25,6 @@ struct rxe_task {
        void                    *arg;
        int                     (*func)(void *arg);
        int                     ret;
-       char                    name[16];
        bool                    destroyed;
 };
 
@@ -34,8 +33,7 @@ struct rxe_task {
  *     arg  => parameter to pass to fcn
  *     func => function to call until it returns != 0
  */
-int rxe_init_task(struct rxe_task *task,
-                 void *arg, int (*func)(void *), char *name);
+int rxe_init_task(struct rxe_task *task, void *arg, int (*func)(void *));
 
 /* cleanup task */
 void rxe_cleanup_task(struct rxe_task *task);