hwrng: starfive - Fix dev_err_probe return error
authorJia Jie Ho <jiajie.ho@starfivetech.com>
Mon, 20 Nov 2023 15:11:21 +0000 (23:11 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Feb 2024 20:14:16 +0000 (20:14 +0000)
[ Upstream commit 2d37b3649c412b3bcecfea932cb677f7a5775b15 ]

Current dev_err_probe will return 0 instead of proper error code if
driver failed to get irq number. Fix the return err code.

Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202311160649.3GhKCfhd-lkp@intel.com/
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/hw_random/jh7110-trng.c

index 38474d4..b1f94e3 100644 (file)
@@ -300,7 +300,7 @@ static int starfive_trng_probe(struct platform_device *pdev)
        ret = devm_request_irq(&pdev->dev, irq, starfive_trng_irq, 0, pdev->name,
                               (void *)trng);
        if (ret)
-               return dev_err_probe(&pdev->dev, irq,
+               return dev_err_probe(&pdev->dev, ret,
                                     "Failed to register interrupt handler\n");
 
        trng->hclk = devm_clk_get(&pdev->dev, "hclk");