kunit: Fix reporting of the skipped parameterized tests
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Wed, 17 May 2023 11:18:15 +0000 (13:18 +0200)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 26 May 2023 14:44:03 +0000 (08:44 -0600)
Logs from the parameterized tests that were skipped don't include
SKIP directive thus they are displayed as PASSED. Fix that.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: David Gow <davidgow@google.com>
Reviewed-by: Rae Moar <rmoar@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/kunit/test.c

index d3fb93a..b090479 100644 (file)
@@ -627,9 +627,11 @@ int kunit_run_tests(struct kunit_suite *suite)
 
                                kunit_log(KERN_INFO, &test,
                                          KUNIT_SUBTEST_INDENT KUNIT_SUBTEST_INDENT
-                                         "%s %d %s",
+                                         "%s %d %s%s%s",
                                          kunit_status_to_ok_not_ok(test.status),
-                                         test.param_index + 1, param_desc);
+                                         test.param_index + 1, param_desc,
+                                         test.status == KUNIT_SKIPPED ? " # SKIP " : "",
+                                         test.status == KUNIT_SKIPPED ? test.status_comment : "");
 
                                /* Get next param. */
                                param_desc[0] = '\0';