staging: r8188eu: update status before wps success blinking
authorMartin Kaiser <martin@kaiser.cx>
Sun, 18 Sep 2022 17:56:56 +0000 (19:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 24 Sep 2022 11:09:18 +0000 (13:09 +0200)
Always update the status variables in rtw_led_control when we start
blinking to show that wps was successful. The if statements are not
necessary.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220918175700.215170-3-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c

index 389fb2c..eac35f0 100644 (file)
@@ -324,20 +324,11 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
        case LED_CTL_STOP_WPS:
                cancel_delayed_work(&pLed->blink_work);
 
-               if (pLed->bLedNoLinkBlinkInProgress)
-                       pLed->bLedNoLinkBlinkInProgress = false;
-
-               if (pLed->bLedLinkBlinkInProgress)
-                       pLed->bLedLinkBlinkInProgress = false;
-
-               if (pLed->bLedBlinkInProgress)
-                       pLed->bLedBlinkInProgress = false;
-
-               if (pLed->bLedScanBlinkInProgress)
-                       pLed->bLedScanBlinkInProgress = false;
-
-               if (!pLed->bLedWPSBlinkInProgress)
-                       pLed->bLedWPSBlinkInProgress = true;
+               pLed->bLedNoLinkBlinkInProgress = false;
+               pLed->bLedLinkBlinkInProgress = false;
+               pLed->bLedBlinkInProgress = false;
+               pLed->bLedScanBlinkInProgress = false;
+               pLed->bLedWPSBlinkInProgress = true;
 
                pLed->CurrLedState = LED_BLINK_WPS_STOP;
                if (pLed->bLedOn) {