Input: ims-pcu - constify attribute_group structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 11 Jul 2017 03:18:03 +0000 (20:18 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 12 Jul 2017 21:18:29 +0000 (14:18 -0700)
attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
  13547    1600       0   15147    3b2b drivers/input/misc/ims-pcu.o

File size After adding 'const':
   text    data     bss     dec     hex filename
  13675    1472       0   15147    3b2b drivers/input/misc/ims-pcu.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/ims-pcu.c

index f4e8fbe..6bf82ea 100644 (file)
@@ -1261,7 +1261,7 @@ static umode_t ims_pcu_is_attr_visible(struct kobject *kobj,
        return mode;
 }
 
-static struct attribute_group ims_pcu_attr_group = {
+static const struct attribute_group ims_pcu_attr_group = {
        .is_visible     = ims_pcu_is_attr_visible,
        .attrs          = ims_pcu_attrs,
 };
@@ -1480,7 +1480,7 @@ static struct attribute *ims_pcu_ofn_attrs[] = {
        NULL
 };
 
-static struct attribute_group ims_pcu_ofn_attr_group = {
+static const struct attribute_group ims_pcu_ofn_attr_group = {
        .name   = "ofn",
        .attrs  = ims_pcu_ofn_attrs,
 };