gst/ffmpegcolorspace/gstffmpegcolorspace.c: Well, unreffing a buffer right before...

Original commit message from CVS:
* gst/ffmpegcolorspace/gstffmpegcolorspace.c:
(gst_ffmpegcsp_getcaps), (gst_ffmpegcsp_configure_context),
(gst_ffmpegcsp_setcaps), (gst_ffmpegcsp_chain):
Well, unreffing a buffer right before pushing it is asking
for trouble..

diff --git a/ChangeLog b/ChangeLog
index f0ecefe..cd612f0 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2005-05-06  Wim Taymans  <wim@fluendo.com>
+
+       * gst/ffmpegcolorspace/gstffmpegcolorspace.c:
+       (gst_ffmpegcsp_getcaps), (gst_ffmpegcsp_configure_context),
+       (gst_ffmpegcsp_setcaps), (gst_ffmpegcsp_chain):
+       Well, unreffing a buffer right before pushing it is asking
+       for trouble..
+
 2005-05-06  Christian Schaller  <uraeus@gnome.org>
 
        * pkgconfig/gstreamer-libs.pc.in: add missing library calls

diff --git a/gst/ffmpegcolorspace/gstffmpegcolorspace.c b/gst/ffmpegcolorspace/gstffmpegcolorspace.c
index 8eb90c8..c492cf7 100644 (file)
--- a/gst/ffmpegcolorspace/gstffmpegcolorspace.c
+++ b/gst/ffmpegcolorspace/gstffmpegcolorspace.c
@@ -247,7 +247,7 @@ gst_ffmpegcsp_setcaps (GstPad * pad, GstCaps * caps)
   par = gst_structure_get_value (structure, "pixel-aspect-ratio");
 
   if (!gst_ffmpegcsp_configure_context (pad, caps, width, height))
-    return FALSE;
+    goto configure_error;
 
   *prefered = caps;
 
@@ -288,6 +288,12 @@ gst_ffmpegcsp_setcaps (GstPad * pad, GstCaps * caps)
   space->height = height;
 
   return TRUE;
+
+configure_error:
+  {
+    GST_DEBUG ("could not configure context");
+    return FALSE;
+  }
 }
 
 static GType
@@ -397,8 +403,9 @@ gst_ffmpegcsp_chain (GstPad * pad, GstBuffer * buffer)
   }
 
   if (space->from_pixfmt == space->to_pixfmt) {
+    GST_DEBUG ("passthrough conversion %" GST_PTR_FORMAT,
+        GST_PAD_CAPS (space->srcpad));
     outbuf = inbuf;
-    gst_buffer_unref (outbuf);
   } else {
     /* convert */
     gst_ffmpegcsp_avpicture_fill (&space->from_frame,