Revert "Make sure clk scaling happens only when HBA is runtime ACTIVE"
authorCan Guo <cang@codeaurora.org>
Wed, 20 Jan 2021 10:04:23 +0000 (02:04 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 21 Jan 2021 03:23:56 +0000 (22:23 -0500)
Commit 73cc291c2702 ("scsi: ufs: Make sure clk scaling happens only
when HBA is runtime ACTIVE") is no longer needed since commit
0e9d4ca43ba8 ("scsi: ufs: Protect some contexts from unexpected clock
scaling") is a more mature fix to protect UFS LLD stability from clock
scaling invoked through sysfs nodes by users.

Link: https://lore.kernel.org/r/1611137065-14266-4-git-send-email-cang@codeaurora.org
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Can Guo <cang@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c

index edb2987..2c3c06b 100644 (file)
@@ -1352,15 +1352,8 @@ static int ufshcd_devfreq_target(struct device *dev,
        }
        spin_unlock_irqrestore(hba->host->host_lock, irq_flags);
 
-       pm_runtime_get_noresume(hba->dev);
-       if (!pm_runtime_active(hba->dev)) {
-               pm_runtime_put_noidle(hba->dev);
-               ret = -EAGAIN;
-               goto out;
-       }
        start = ktime_get();
        ret = ufshcd_devfreq_scale(hba, scale_up);
-       pm_runtime_put(hba->dev);
 
        trace_ufshcd_profile_clk_scaling(dev_name(hba->dev),
                (scale_up ? "up" : "down"),