platform/x86/siemens: simatic-ipc: fix logical error for BX-59A
authorxingtong.wu <xingtong.wu@siemens.com>
Wed, 2 Aug 2023 17:35:15 +0000 (01:35 +0800)
committerHans de Goede <hdegoede@redhat.com>
Thu, 10 Aug 2023 08:42:11 +0000 (10:42 +0200)
The variable "ledmode" is missing from if statement that leads to
a logical error. Add the missing variable to the if condition.

Fixes: b8af77951941 ("platform/x86/siemens: simatic-ipc: add new models BX-56A/BX-59A")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307312322.Aa8upHWK-lkp@intel.com/
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: xingtong.wu <xingtong.wu@siemens.com>
Link: https://lore.kernel.org/r/20430802173515.2363-2-xingtong_wu@163.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/siemens/simatic-ipc.c

index 02c540c..8ca6e27 100644 (file)
@@ -129,7 +129,7 @@ static int register_platform_devices(u32 station_id)
                pdevname = KBUILD_MODNAME "_leds";
                if (ledmode == SIMATIC_IPC_DEVICE_127E)
                        pdevname = KBUILD_MODNAME "_leds_gpio_apollolake";
-               if (ledmode == SIMATIC_IPC_DEVICE_227G || SIMATIC_IPC_DEVICE_BX_59A)
+               if (ledmode == SIMATIC_IPC_DEVICE_227G || ledmode == SIMATIC_IPC_DEVICE_BX_59A)
                        pdevname = KBUILD_MODNAME "_leds_gpio_f7188x";
                if (ledmode == SIMATIC_IPC_DEVICE_BX_21A)
                        pdevname = KBUILD_MODNAME "_leds_gpio_elkhartlake";