ASoC: SOF: Intel: use def_tristate, avoid using select
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 1 Nov 2019 17:30:40 +0000 (12:30 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 4 Nov 2019 13:24:14 +0000 (13:24 +0000)
So far we used select to use the relevant built-in/module options, but
this led to blurring layers between core and Intel Kconfigs.

Use def_tristate works just as well and removes Intel stuff from the code.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20191101173045.27099-7-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/Kconfig
sound/soc/sof/intel/Kconfig

index 6435eb5..71a0fc0 100644 (file)
@@ -14,7 +14,6 @@ config SND_SOC_SOF_PCI
        depends on PCI
        select SND_SOC_SOF
        select SND_SOC_ACPI if ACPI
-       select SND_SOC_SOF_INTEL_PCI if SND_SOC_SOF_INTEL_TOPLEVEL
        help
          This adds support for PCI enumeration. This option is
          required to enable Intel Skylake+ devices
@@ -26,7 +25,6 @@ config SND_SOC_SOF_ACPI
        depends on ACPI || COMPILE_TEST
        select SND_SOC_SOF
        select SND_SOC_ACPI if ACPI
-       select SND_SOC_SOF_INTEL_ACPI if SND_SOC_SOF_INTEL_TOPLEVEL
        select IOSF_MBI if X86 && PCI
        help
          This adds support for ACPI enumeration. This option is required
index cd9954b..04d4929 100644 (file)
@@ -10,7 +10,7 @@ config SND_SOC_SOF_INTEL_TOPLEVEL
 if SND_SOC_SOF_INTEL_TOPLEVEL
 
 config SND_SOC_SOF_INTEL_ACPI
-       tristate
+       def_tristate SND_SOC_SOF_ACPI
        select SND_SOC_SOF_BAYTRAIL  if SND_SOC_SOF_BAYTRAIL_SUPPORT
        select SND_SOC_SOF_BROADWELL if SND_SOC_SOF_BROADWELL_SUPPORT
        help
@@ -18,7 +18,7 @@ config SND_SOC_SOF_INTEL_ACPI
          'select' statements at a higher level
 
 config SND_SOC_SOF_INTEL_PCI
-       tristate
+       def_tristate SND_SOC_SOF_PCI
        select SND_SOC_SOF_MERRIFIELD  if SND_SOC_SOF_MERRIFIELD_SUPPORT
        select SND_SOC_SOF_APOLLOLAKE  if SND_SOC_SOF_APOLLOLAKE_SUPPORT
        select SND_SOC_SOF_GEMINILAKE  if SND_SOC_SOF_GEMINILAKE_SUPPORT