gdrom: fix a memory leak bug
authorWenwen Wang <wang6495@umn.edu>
Thu, 27 Dec 2018 02:15:13 +0000 (20:15 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Feb 2019 09:09:03 +0000 (10:09 +0100)
[ Upstream commit 093c48213ee37c3c3ff1cf5ac1aa2a9d8bc66017 ]

In probe_gdrom(), the buffer pointed by 'gd.cd_info' is allocated through
kzalloc() and is used to hold the information of the gdrom device. To
register and unregister the device, the pointer 'gd.cd_info' is passed to
the functions register_cdrom() and unregister_cdrom(), respectively.
However, this buffer is not freed after it is used, which can cause a
memory leak bug.

This patch simply frees the buffer 'gd.cd_info' in exit_gdrom() to fix the
above issue.

Signed-off-by: Wenwen Wang <wang6495@umn.edu>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/cdrom/gdrom.c

index e2808fe..1852d19 100644 (file)
@@ -882,6 +882,7 @@ static void __exit exit_gdrom(void)
        platform_device_unregister(pd);
        platform_driver_unregister(&gdrom_driver);
        kfree(gd.toc);
+       kfree(gd.cd_info);
 }
 
 module_init(init_gdrom);