config: Fix check for argp_parse to pass &argv

Right now it's passing a char* when it expects a char** instead.

This usually produces a warning that may go unnoticed, but if CFLAGS
contains -Werror, that breaks the ./configure run with the following
error:

  $ ./configure CFLAGS=-Werror
  ...
  configure: WARNING: "libc does not have argp"
  checking for argp_parse in -largp... no
  configure: error: "no libargp found"

Tested: Checked that after this fix, running ./configure CFLAGS=-Werror
works as expected and argp_parse is correctly detected.

Signed-off-by: Filipe Brandenburger <filbranden@google.com>

diff --git a/ChangeLog b/ChangeLog
index 31f346f..f2b5c8f 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2016-05-02  Filipe Brandenburger  <filbranden@google.com>
+
+       * configure.ac (argp check): Pass pass &argv.
+
 2016-03-31  Mark Wielaard  <mjw@redhat.com>
 
        * configure.ac: Set version to 0.166.

diff --git a/configure.ac b/configure.ac
index 86a69c6..72cb22e 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -340,7 +340,7 @@ dnl Check if we have argp available from our libc
 AC_LINK_IFELSE(
        [AC_LANG_PROGRAM(
                [#include <argp.h>],
-               [int argc=1; char *argv[]={"test"}; argp_parse(0,argc,argv,0,0,0); return 0;]
+               [int argc=1; char *argv[]={"test"}; argp_parse(0,argc,&argv,0,0,0); return 0;]
                )],
        [libc_has_argp="true"],
        [libc_has_argp="false"]