iio: adc: hx711: Fix buffer alignment in iio_push_to_buffers_with_timestamp()
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 13 Jun 2021 15:22:55 +0000 (16:22 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 14 Jun 2021 10:42:41 +0000 (11:42 +0100)
To make code more readable, use a structure to express the channel
layout and ensure the timestamp is 8 byte aligned.

Found during an audit of all calls of this function.

Fixes: d3bf60450d47 ("iio: hx711: add triggered buffer support")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Andreas Klinger <ak@it-klinger.de>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210613152301.571002-3-jic23@kernel.org
drivers/iio/adc/hx711.c

index 6a17353..f7ee856 100644 (file)
@@ -86,9 +86,9 @@ struct hx711_data {
        struct mutex            lock;
        /*
         * triggered buffer
-        * 2x32-bit channel + 64-bit timestamp
+        * 2x32-bit channel + 64-bit naturally aligned timestamp
         */
-       u32                     buffer[4];
+       u32                     buffer[4] __aligned(8);
        /*
         * delay after a rising edge on SCK until the data is ready DOUT
         * this is dependent on the hx711 where the datasheet tells a