Use dict.get to simplify test and iteration
authorHugh Brown <hbrown@amplify.com>
Thu, 10 Oct 2013 22:00:49 +0000 (18:00 -0400)
committerHugh Brown <hbrown@amplify.com>
Thu, 10 Oct 2013 22:41:39 +0000 (18:41 -0400)
jenkinsapi/view.py

index 5312d06..3371800 100644 (file)
@@ -151,11 +151,8 @@ class View(JenkinsBase):
         return True
 
     def _get_nested_views(self):
-        if not 'views' in self._data:
-            pass
-        else:
-            for viewdict in self._data["views"]:
-                yield viewdict["name"], viewdict["url"]
+        for viewdict in self._data.get("views", []):
+            yield viewdict["name"], viewdict["url"]
 
     def get_nested_view_dict(self):
         return dict(self._get_nested_views())