Windows: Stop manipulating line numbering in versioninfo.rc
authorSimon McVittie <smcv@collabora.com>
Fri, 6 Oct 2017 12:00:39 +0000 (13:00 +0100)
committerRalf Habacker <ralf.habacker@freenet.de>
Tue, 17 Oct 2017 18:24:11 +0000 (20:24 +0200)
If __LINE__ doesn't work in MSVC's resource compiler, then removing
the #line directive altogether seems a simpler fix than redefining
__LINE__ to the wrong value.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=103015
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
cmake/dbus/CMakeLists.txt
dbus/versioninfo.rc.in

index 4267494..4b2eac3 100644 (file)
@@ -246,7 +246,6 @@ if (MSVC)
     
     configure_file(${DBUS_DIR}/versioninfo.rc.in ${CMAKE_CURRENT_BINARY_DIR}/versioninfo.rc)
     list(APPEND libdbus_SOURCES versioninfo.rc)
-    set_source_files_properties(versioninfo.rc COMPILE_FLAGS "-D__LINE__=1")
 endif (MSVC)
 
 if(MSVC_IDE)
index 354c343..3b2b018 100644 (file)
  
 /* This file is processed by configure to create versioninfo.rc */
 
-#line __LINE__ "versioninfo.rc.in"
-
-
-
 VS_VERSION_INFO VERSIONINFO
  FILEVERSION @BUILD_FILEVERSION@
  PRODUCTVERSION @BUILD_FILEVERSION@