sfc: falcon: convert to use i2c_new_client_device()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 26 Mar 2020 21:10:00 +0000 (22:10 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Mar 2020 02:31:21 +0000 (19:31 -0700)
Move away from the deprecated API and return the shiny new ERRPTR where
useful.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/falcon/falcon_boards.c

index 605f486..729a05c 100644 (file)
@@ -88,11 +88,11 @@ static int ef4_init_lm87(struct ef4_nic *efx, const struct i2c_board_info *info,
                         const u8 *reg_values)
 {
        struct falcon_board *board = falcon_board(efx);
-       struct i2c_client *client = i2c_new_device(&board->i2c_adap, info);
+       struct i2c_client *client = i2c_new_client_device(&board->i2c_adap, info);
        int rc;
 
-       if (!client)
-               return -EIO;
+       if (IS_ERR(client))
+               return PTR_ERR(client);
 
        /* Read-to-clear alarm/interrupt status */
        i2c_smbus_read_byte_data(client, LM87_REG_ALARMS1);