staging: gasket: apex: convert various logs to debug level
authorTodd Poynor <toddpoynor@google.com>
Sat, 21 Jul 2018 13:35:07 +0000 (06:35 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jul 2018 11:56:46 +0000 (13:56 +0200)
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs.  Convert these to debug log level.

Signed-off-by: Zhongze Hu <frankhu@chromium.org>
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/apex_driver.c

index 1c6f73b..6396b18 100644 (file)
@@ -420,7 +420,7 @@ static int apex_device_cleanup(struct gasket_dev *gasket_dev)
                gasket_dev, APEX_BAR_INDEX,
                APEX_BAR2_REG_SCALAR_CORE_ERROR_STATUS);
 
-       gasket_log_info(
+       gasket_log_debug(
                gasket_dev,
                "%s 0x%p hib_error 0x%llx scalar_error "
                "0x%llx.",
@@ -589,7 +589,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev, uint type)
                        SCU3_RG_PWR_STATE_OVR_BIT_OFFSET);
                val1 = gasket_dev_read_32(
                        gasket_dev, APEX_BAR_INDEX, APEX_BAR2_REG_SCU_3);
-               gasket_log_error(
+               gasket_log_debug(
                        gasket_dev, "Disallow HW clock gating 0x%x -> 0x%x",
                        val0, val1);
        } else {
@@ -602,7 +602,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev, uint type)
                        SCU3_RG_PWR_STATE_OVR_BIT_OFFSET);
                val1 = gasket_dev_read_32(
                        gasket_dev, APEX_BAR_INDEX, APEX_BAR2_REG_SCU_3);
-               gasket_log_error(
+               gasket_log_debug(
                        gasket_dev, "Allow HW clock gating 0x%x -> 0x%x", val0,
                        val1);
        }
@@ -668,7 +668,7 @@ static long apex_clock_gating(struct gasket_dev *gasket_dev,
        if (copy_from_user(&ibuf, argp, sizeof(ibuf)))
                return -EFAULT;
 
-       gasket_log_error(gasket_dev, "%s %llu", __func__, ibuf.enable);
+       gasket_log_debug(gasket_dev, "%s %llu", __func__, ibuf.enable);
 
        if (ibuf.enable) {
                /* Quiesce AXI, gate GCB clock. */
@@ -738,7 +738,7 @@ static ssize_t sysfs_show(
                                        gasket_dev->page_table[0]));
                break;
        default:
-               gasket_log_error(
+               gasket_log_debug(
                        gasket_dev, "Unknown attribute: %s", attr->attr.name);
                ret = 0;
                break;