Fix spurious failures on KHR-GL30.transform_feedback.api_errors_test
authorEric Anholt <anholt@google.com>
Wed, 3 Feb 2021 20:08:33 +0000 (12:08 -0800)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Thu, 25 Feb 2021 18:52:24 +0000 (18:52 +0000)
The list of valid prims was missing that compat contexts have GL_QUADS
as a valid prim type, so the GL30/31 tests would fail, or later
contexts that include ARB_compat by default.

This addition follows the existing model of the GS primitive types
where we always avoid them when looking for an invalid prim enum,
rather than tess's model where we make a point of picking GL_PATCHES
if the test thinks tess is unsupported.

VK-GL-CTS issue: 2717

Components: OpenGL

Affects: KHR-GL3*.transform_feedback.api_errors_test
Change-Id: Ie8f3a554d7de9efb4ca7356fefff5028c9ffa45f

external/openglcts/modules/gl/gl3cTransformFeedbackTests.cpp

index a461ac4..4e5bd7c 100644 (file)
@@ -1380,6 +1380,7 @@ bool gl3cts::TransformFeedback::APIErrors::testInstanced(void)
                                                                          GL_TRIANGLES,
                                                                          GL_TRIANGLE_STRIP_ADJACENCY,
                                                                          GL_TRIANGLES_ADJACENCY,
+                                                                         GL_QUADS,
                                                                          GL_PATCHES };
 
        std::set<glw::GLenum> supported_mode(_supported_mode,