media: vimc: wrong pointer is used with PTR_ERR

Fix smatch warning:

drivers/media/test-drivers/vimc/vimc-core.c:214 vimc_create_links() warn: passing a valid pointer to 'PTR_ERR'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/media/test-drivers/vimc/vimc-core.c b/drivers/media/test-drivers/vimc/vimc-core.c
index c73f919..2ae7a0f 100644 (file)
--- a/drivers/media/test-drivers/vimc/vimc-core.c
+++ b/drivers/media/test-drivers/vimc/vimc-core.c
@@ -211,7 +211,7 @@ static int vimc_create_links(struct vimc_device *vimc)
                        media_create_ancillary_link(ved_primary->ent, ved_ancillary->ent);
 
                if (IS_ERR(ret_link)) {
-                       ret = PTR_ERR(link);
+                       ret = PTR_ERR(ret_link);
                        goto err_rm_links;
                }
        }