ASoC: SOF: ipc4-pcm: allocate time info for pcm delay feature
authorRander Wang <rander.wang@intel.com>
Thu, 2 Feb 2023 13:29:49 +0000 (15:29 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 3 Feb 2023 12:03:50 +0000 (12:03 +0000)
Allocate time info when pcm is loaded by topology
and free it when pcm is unloaded by topology.

Signed-off-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230202132954.26773-5-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-pcm.c

index 521090d..8071db4 100644 (file)
@@ -12,6 +12,7 @@
 #include "sof-priv.h"
 #include "ipc4-priv.h"
 #include "ipc4-topology.h"
+#include "ipc4-fw-reg.h"
 
 static int sof_ipc4_set_multi_pipeline_state(struct snd_sof_dev *sdev, u32 state,
                                             struct ipc4_pipeline_set_state_data *trigger_list)
@@ -410,6 +411,8 @@ static void sof_ipc4_pcm_free(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm
                pipeline_list = &spcm->stream[stream].pipeline_list;
                kfree(pipeline_list->pipelines);
                pipeline_list->pipelines = NULL;
+               kfree(spcm->stream[stream].private);
+               spcm->stream[stream].private = NULL;
        }
 }
 
@@ -417,8 +420,19 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm
 {
        struct snd_sof_pcm_stream_pipeline_list *pipeline_list;
        struct sof_ipc4_fw_data *ipc4_data = sdev->private;
+       struct sof_ipc4_timestamp_info *stream_info;
+       bool support_info = true;
+       u32 abi_version;
+       u32 abi_offset;
        int stream;
 
+       abi_offset = offsetof(struct sof_ipc4_fw_registers, abi_ver);
+       sof_mailbox_read(sdev, sdev->fw_info_box.offset + abi_offset, &abi_version,
+                        sizeof(abi_version));
+
+       if (abi_version < SOF_IPC4_FW_REGS_ABI_VER)
+               support_info = false;
+
        for_each_pcm_streams(stream) {
                pipeline_list = &spcm->stream[stream].pipeline_list;
 
@@ -429,6 +443,17 @@ static int sof_ipc4_pcm_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm
                        sof_ipc4_pcm_free(sdev, spcm);
                        return -ENOMEM;
                }
+
+               if (!support_info)
+                       continue;
+
+               stream_info = kzalloc(sizeof(*stream_info), GFP_KERNEL);
+               if (!stream_info) {
+                       sof_ipc4_pcm_free(sdev, spcm);
+                       return -ENOMEM;
+               }
+
+               spcm->stream[stream].private = stream_info;
        }
 
        return 0;