scsi: qla2xxx: Check valid rport returned by fc_bsg_to_rport()
authorNilesh Javali <njavali@marvell.com>
Wed, 7 Jun 2023 11:38:39 +0000 (17:08 +0530)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 15 Jun 2023 02:06:02 +0000 (22:06 -0400)
Klocwork reported warning of rport maybe NULL and will be dereferenced.
rport returned by call to fc_bsg_to_rport() could be NULL and dereferenced.

Check valid rport returned by fc_bsg_to_rport().

Cc: stable@vger.kernel.org
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Link: https://lore.kernel.org/r/20230607113843.37185-5-njavali@marvell.com
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_bsg.c

index dba7bba..c928b27 100644 (file)
@@ -283,6 +283,10 @@ qla2x00_process_els(struct bsg_job *bsg_job)
 
        if (bsg_request->msgcode == FC_BSG_RPT_ELS) {
                rport = fc_bsg_to_rport(bsg_job);
+               if (!rport) {
+                       rval = -ENOMEM;
+                       goto done;
+               }
                fcport = *(fc_port_t **) rport->dd_data;
                host = rport_to_shost(rport);
                vha = shost_priv(host);