leds: trigger: netdev: Remove NULL check before dev_{put, hold}

The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold},
remove it to silence the warnings:

./drivers/leds/trigger/ledtrig-netdev.c:291:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed.
./drivers/leds/trigger/ledtrig-netdev.c:401:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=4929
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/20230511070820.52731-1-yang.lee@linux.alibaba.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/trigger/ledtrig-netdev.c b/drivers/leds/trigger/ledtrig-netdev.c
index 305eb543ba84f3ffc9b03e877510a393ce358ac8..92de22be5f1c84d6798052e5a7b1202cf1ebfcde 100644 (file)
--- a/drivers/leds/trigger/ledtrig-netdev.c
+++ b/drivers/leds/trigger/ledtrig-netdev.c
@@ -287,8 +287,7 @@ static int netdev_trig_notify(struct notifier_block *nb,
                trigger_data->carrier_link_up = netif_carrier_ok(dev);
                fallthrough;
        case NETDEV_REGISTER:
-               if (trigger_data->net_dev)
-                       dev_put(trigger_data->net_dev);
+               dev_put(trigger_data->net_dev);
                dev_hold(dev);
                trigger_data->net_dev = dev;
                break;
@@ -397,8 +396,7 @@ static void netdev_trig_deactivate(struct led_classdev *led_cdev)
 
        cancel_delayed_work_sync(&trigger_data->work);
 
-       if (trigger_data->net_dev)
-               dev_put(trigger_data->net_dev);
+       dev_put(trigger_data->net_dev);
 
        kfree(trigger_data);
 }