hisi_acc_vfio_pci: Remove useless function parameter
authorLongfang Liu <liulongfang@huawei.com>
Mon, 26 Sep 2022 09:33:30 +0000 (17:33 +0800)
committerAlex Williamson <alex.williamson@redhat.com>
Tue, 27 Sep 2022 15:30:31 +0000 (09:30 -0600)
Remove unused function parameters for vf_qm_fun_reset() and
ensure the device is enabled before the reset operation
is performed.

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Longfang Liu <liulongfang@huawei.com>
Link: https://lore.kernel.org/r/20220926093332.28824-4-liulongfang@huawei.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c

index fbe72ce..c07ed7b 100644 (file)
@@ -337,8 +337,7 @@ static int vf_qm_cache_wb(struct hisi_qm *qm)
        return 0;
 }
 
-static void vf_qm_fun_reset(struct hisi_acc_vf_core_device *hisi_acc_vdev,
-                           struct hisi_qm *qm)
+static void vf_qm_fun_reset(struct hisi_qm *qm)
 {
        int i;
 
@@ -662,7 +661,10 @@ static void hisi_acc_vf_start_device(struct hisi_acc_vf_core_device *hisi_acc_vd
        if (hisi_acc_vdev->vf_qm_state != QM_READY)
                return;
 
-       vf_qm_fun_reset(hisi_acc_vdev, vf_qm);
+       /* Make sure the device is enabled */
+       qm_dev_cmd_init(vf_qm);
+
+       vf_qm_fun_reset(vf_qm);
 }
 
 static int hisi_acc_vf_load_state(struct hisi_acc_vf_core_device *hisi_acc_vdev)