i2c: i801: Use match_string() helper to simplify the code
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 21 Jun 2019 11:36:24 +0000 (14:36 +0300)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 21 Jun 2019 21:09:24 +0000 (23:09 +0200)
match_string() returns the array index of a matching string.
Use it instead of the open-coded implementation.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-i801.c

index 7d14b67..88e4dd2 100644 (file)
 #include <linux/io.h>
 #include <linux/dmi.h>
 #include <linux/slab.h>
+#include <linux/string.h>
 #include <linux/wait.h>
 #include <linux/err.h>
 #include <linux/platform_device.h>
@@ -1172,14 +1173,12 @@ static acpi_status check_acpi_smo88xx_device(acpi_handle obj_handle,
        if (!hid)
                return AE_OK;
 
-       for (i = 0; i < ARRAY_SIZE(acpi_smo8800_ids); ++i) {
-               if (strcmp(hid, acpi_smo8800_ids[i]) == 0) {
-                       *((bool *)return_value) = true;
-                       return AE_CTRL_TERMINATE;
-               }
-       }
+       i = match_string(acpi_smo8800_ids, ARRAY_SIZE(acpi_smo8800_ids), hid);
+       if (i < 0)
+               return AE_OK;
 
-       return AE_OK;
+       *((bool *)return_value) = true;
+       return AE_CTRL_TERMINATE;
 }
 
 static bool is_dell_system_with_lis3lv02d(void)