projects
/
platform
/
kernel
/
linux-amlogic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0e253b4
)
ALSA: opl3: fix infoleak in opl3
author
xidongwang
<wangxidong_97@163.com>
Mon, 6 Jul 2020 03:27:38 +0000
(20:27 -0700)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 22 Jul 2020 07:10:46 +0000
(09:10 +0200)
commit
ad155712bb1ea2151944cf06a0e08c315c70c1e3
upstream.
The stack object “info” in snd_opl3_ioctl() has a leaking problem.
It has 2 padding bytes which are not initialized and leaked via
“copy_to_user”.
Signed-off-by: xidongwang <wangxidong_97@163.com>
Cc: <stable@vger.kernel.org>
Link:
https://lore.kernel.org/r/1594006058-30362-1-git-send-email-wangxidong_97@163.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/drivers/opl3/opl3_synth.c
patch
|
blob
|
history
diff --git
a/sound/drivers/opl3/opl3_synth.c
b/sound/drivers/opl3/opl3_synth.c
index
42920a2
..
3f94746
100644
(file)
--- a/
sound/drivers/opl3/opl3_synth.c
+++ b/
sound/drivers/opl3/opl3_synth.c
@@
-104,6
+104,8
@@
int snd_opl3_ioctl(struct snd_hwdep * hw, struct file *file,
{
struct snd_dm_fm_info info;
+ memset(&info, 0, sizeof(info));
+
info.fm_mode = opl3->fm_mode;
info.rhythm = opl3->rhythm;
if (copy_to_user(argp, &info, sizeof(struct snd_dm_fm_info)))