re-enable MulticastInterface test on RH6, disable on RH7 and OSX (dotnet/corefx#35798)
authorTomas Weinfurt <tweinfurt@yahoo.com>
Wed, 6 Mar 2019 19:08:38 +0000 (11:08 -0800)
committerGitHub <noreply@github.com>
Wed, 6 Mar 2019 19:08:38 +0000 (11:08 -0800)
* re-enable MulticastInterface test on RH6, disable on RH7 and OSX

* add missing using

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/ebe74b3ad7d1b7be02217bf199f5dedc05f76297

src/libraries/System.Net.Sockets/tests/FunctionalTests/SocketOptionNameTest.cs

index 704166f..9adeea0 100644 (file)
@@ -8,7 +8,7 @@ using System.Runtime.InteropServices;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
-
+using Microsoft.DotNet.XUnitExtensions;
 using Xunit;
 
 namespace System.Net.Sockets.Tests
@@ -87,11 +87,6 @@ namespace System.Net.Sockets.Tests
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] // ActiveIssue: dotnet/corefx #29929
         public async Task MulticastInterface_Set_AnyInterface_Succeeds()
         {
-            if (PlatformDetection.IsRedHatFamily6)
-            {
-                return; // [ActiveIssue(34809)]
-            }
-
             // On all platforms, index 0 means "any interface"
             await MulticastInterface_Set_Helper(0);
         }
@@ -157,11 +152,13 @@ namespace System.Net.Sockets.Tests
 
         [OuterLoop] // TODO: Issue #11345
         [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))] // ActiveIssue: dotnet/corefx #29929
+        [PlatformSpecific(~TestPlatforms.OSX)]
         public async Task MulticastInterface_Set_IPv6_AnyInterface_Succeeds()
         {
-            if (PlatformDetection.IsRedHatFamily6)
+            if (PlatformDetection.IsRedHatFamily7)
             {
-                return; // [ActiveIssue(34809)]
+                // RH7 seems to have issues with multicast in Azure. Same code and setup can pass when executed outside of Azure.
+                throw new SkipTestException("IPv6 multicast environment not available");
             }
 
             // On all platforms, index 0 means "any interface"