ALSA: vx: Use roundup() instead of open-coding it
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 23 Dec 2020 17:22:23 +0000 (18:22 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 25 Dec 2020 08:11:53 +0000 (09:11 +0100)
Use roundup() instead of open-coding it. This documents intent
and makes it more clear what is going on for the casual reviewer.

Generated using the following the Coccinelle semantic patch.

// <smpl>
@@
expression x, y;
@@
-((((x) + (y) - 1) / (y)) * y)
+roundup(x, y)
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201223172229.781-12-lars@metafoo.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/vx/vx_pcm.c

index 3d2e3bc..daffda9 100644 (file)
@@ -1154,8 +1154,7 @@ static int vx_init_audio_io(struct vx_core *chip)
        chip->ibl.size = 0;
        vx_set_ibl(chip, &chip->ibl); /* query the info */
        if (preferred > 0) {
-               chip->ibl.size = ((preferred + chip->ibl.granularity - 1) /
-                                 chip->ibl.granularity) * chip->ibl.granularity;
+               chip->ibl.size = roundup(preferred, chip->ibl.granularity);
                if (chip->ibl.size > chip->ibl.max_size)
                        chip->ibl.size = chip->ibl.max_size;
        } else