mmc: bcm2835: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Wed, 2 Sep 2020 19:36:48 +0000 (21:36 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 7 Sep 2020 07:11:32 +0000 (09:11 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20200902193658.20539-2-krzk@kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/bcm2835.c

index a076779..35320bc 100644 (file)
@@ -1406,9 +1406,7 @@ static int bcm2835_probe(struct platform_device *pdev)
 
        clk = devm_clk_get(dev, NULL);
        if (IS_ERR(clk)) {
-               ret = PTR_ERR(clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "could not get clk: %d\n", ret);
+               ret = dev_err_probe(dev, PTR_ERR(clk), "could not get clk\n");
                goto err;
        }