rt2x00: convert rt2x00_rf_read return type

This is a semi-automated conversion to change rt2x00_rf_read()
to return the register contents instead of passing them by value,
resulting in much better object code. The majority of the patch
was done using:

sed -i 's:\(\<rt2x00_rf_read\>(.*, .*\), &\(.*\));:\2 = \1);:' \
	drivers/net/wireless/ralink/rt2x00/rt*

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2400pci.c b/drivers/net/wireless/ralink/rt2x00/rt2400pci.c
index 3ba9a16..d418322 100644 (file)
--- a/drivers/net/wireless/ralink/rt2x00/rt2400pci.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2400pci.c
@@ -199,7 +199,7 @@ static const struct rt2x00debug rt2400pci_rt2x00debug = {
                .word_count     = BBP_SIZE / sizeof(u8),
        },
        .rf     = {
-               .read           = _rt2x00_rf_read,
+               .read           = rt2x00_rf_read,
                .write          = rt2400pci_rf_write,
                .word_base      = RF_BASE,
                .word_size      = sizeof(u32),

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2500pci.c b/drivers/net/wireless/ralink/rt2x00/rt2500pci.c
index d9b061b..232feba 100644 (file)
--- a/drivers/net/wireless/ralink/rt2x00/rt2500pci.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2500pci.c
@@ -199,7 +199,7 @@ static const struct rt2x00debug rt2500pci_rt2x00debug = {
                .word_count     = BBP_SIZE / sizeof(u8),
        },
        .rf     = {
-               .read           = _rt2x00_rf_read,
+               .read           = rt2x00_rf_read,
                .write          = rt2500pci_rf_write,
                .word_base      = RF_BASE,
                .word_size      = sizeof(u32),
@@ -556,7 +556,7 @@ static void rt2500pci_config_txpower(struct rt2x00_dev *rt2x00dev,
 {
        u32 rf3;
 
-       rt2x00_rf_read(rt2x00dev, 3, &rf3);
+       rf3 = rt2x00_rf_read(rt2x00dev, 3);
        rt2x00_set_field32(&rf3, RF3_TXPOWER, TXPOWER_TO_DEV(txpower));
        rt2500pci_rf_write(rt2x00dev, 3, rf3);
 }

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2500usb.c b/drivers/net/wireless/ralink/rt2x00/rt2500usb.c
index 5bd160f..9cff9dd 100644 (file)
--- a/drivers/net/wireless/ralink/rt2x00/rt2500usb.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2500usb.c
@@ -268,7 +268,7 @@ static const struct rt2x00debug rt2500usb_rt2x00debug = {
                .word_count     = BBP_SIZE / sizeof(u8),
        },
        .rf     = {
-               .read           = _rt2x00_rf_read,
+               .read           = rt2x00_rf_read,
                .write          = rt2500usb_rf_write,
                .word_base      = RF_BASE,
                .word_size      = sizeof(u32),
@@ -639,7 +639,7 @@ static void rt2500usb_config_txpower(struct rt2x00_dev *rt2x00dev,
 {
        u32 rf3;
 
-       rt2x00_rf_read(rt2x00dev, 3, &rf3);
+       rf3 = rt2x00_rf_read(rt2x00dev, 3);
        rt2x00_set_field32(&rf3, RF3_TXPOWER, TXPOWER_TO_DEV(txpower));
        rt2500usb_rf_write(rt2x00dev, 3, rf3);
 }

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index 9b8c19d..fef53d6 100644 (file)
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -1265,7 +1265,7 @@ const struct rt2x00debug rt2800_rt2x00debug = {
                .word_count     = BBP_SIZE / sizeof(u8),
        },
        .rf     = {
-               .read           = _rt2x00_rf_read,
+               .read           = rt2x00_rf_read,
                .write          = rt2800_rf_write,
                .word_base      = RF_BASE,
                .word_size      = sizeof(u32),

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00.h b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
index f2ae33b..36791f7 100644 (file)
--- a/drivers/net/wireless/ralink/rt2x00/rt2x00.h
+++ b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
@@ -1049,15 +1049,8 @@ struct rt2x00_bar_list_entry {
  * Generic RF access.
  * The RF is being accessed by word index.
  */
-static inline void rt2x00_rf_read(struct rt2x00_dev *rt2x00dev,
-                                 const unsigned int word, u32 *data)
-{
-       BUG_ON(word < 1 || word > rt2x00dev->ops->rf_size / sizeof(u32));
-       *data = rt2x00dev->rf[word - 1];
-}
-
-static inline u32 _rt2x00_rf_read(struct rt2x00_dev *rt2x00dev,
-                                 const unsigned int word)
+static inline u32 rt2x00_rf_read(struct rt2x00_dev *rt2x00dev,
+                                const unsigned int word)
 {
        BUG_ON(word < 1 || word > rt2x00dev->ops->rf_size / sizeof(u32));
        return rt2x00dev->rf[word - 1];

diff --git a/drivers/net/wireless/ralink/rt2x00/rt61pci.c b/drivers/net/wireless/ralink/rt2x00/rt61pci.c
index efe8a76..147d1d2 100644 (file)
--- a/drivers/net/wireless/ralink/rt2x00/rt61pci.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt61pci.c
@@ -236,7 +236,7 @@ static const struct rt2x00debug rt61pci_rt2x00debug = {
                .word_count     = BBP_SIZE / sizeof(u8),
        },
        .rf     = {
-               .read           = _rt2x00_rf_read,
+               .read           = rt2x00_rf_read,
                .write          = rt61pci_rf_write,
                .word_base      = RF_BASE,
                .word_size      = sizeof(u32),
@@ -922,10 +922,10 @@ static void rt61pci_config_txpower(struct rt2x00_dev *rt2x00dev,
 {
        struct rf_channel rf;
 
-       rt2x00_rf_read(rt2x00dev, 1, &rf.rf1);
-       rt2x00_rf_read(rt2x00dev, 2, &rf.rf2);
-       rt2x00_rf_read(rt2x00dev, 3, &rf.rf3);
-       rt2x00_rf_read(rt2x00dev, 4, &rf.rf4);
+       rf.rf1 = rt2x00_rf_read(rt2x00dev, 1);
+       rf.rf2 = rt2x00_rf_read(rt2x00dev, 2);
+       rf.rf3 = rt2x00_rf_read(rt2x00dev, 3);
+       rf.rf4 = rt2x00_rf_read(rt2x00dev, 4);
 
        rt61pci_config_channel(rt2x00dev, &rf, txpower);
 }

diff --git a/drivers/net/wireless/ralink/rt2x00/rt73usb.c b/drivers/net/wireless/ralink/rt2x00/rt73usb.c
index 5db1749..a36dee1 100644 (file)
--- a/drivers/net/wireless/ralink/rt2x00/rt73usb.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt73usb.c
@@ -181,7 +181,7 @@ static const struct rt2x00debug rt73usb_rt2x00debug = {
                .word_count     = BBP_SIZE / sizeof(u8),
        },
        .rf     = {
-               .read           = _rt2x00_rf_read,
+               .read           = rt2x00_rf_read,
                .write          = rt73usb_rf_write,
                .word_base      = RF_BASE,
                .word_size      = sizeof(u32),
@@ -805,10 +805,10 @@ static void rt73usb_config_txpower(struct rt2x00_dev *rt2x00dev,
 {
        struct rf_channel rf;
 
-       rt2x00_rf_read(rt2x00dev, 1, &rf.rf1);
-       rt2x00_rf_read(rt2x00dev, 2, &rf.rf2);
-       rt2x00_rf_read(rt2x00dev, 3, &rf.rf3);
-       rt2x00_rf_read(rt2x00dev, 4, &rf.rf4);
+       rf.rf1 = rt2x00_rf_read(rt2x00dev, 1);
+       rf.rf2 = rt2x00_rf_read(rt2x00dev, 2);
+       rf.rf3 = rt2x00_rf_read(rt2x00dev, 3);
+       rf.rf4 = rt2x00_rf_read(rt2x00dev, 4);
 
        rt73usb_config_channel(rt2x00dev, &rf, txpower);
 }