[PORT FROM R2] atomisp: Address Klocwork critical issue in drivers
authorzheng.zixiang <zixiangx.zheng@intel.com>
Wed, 2 Nov 2011 10:19:02 +0000 (18:19 +0800)
committerbuildbot <buildbot@intel.com>
Mon, 19 Dec 2011 13:27:53 +0000 (05:27 -0800)
BZ: 17272

Fix Klocwork critical issue that index of 'sh_css_blob_info'
may be out of bounds.
Signed-off-by: zheng.zixiang <zixiangx.zheng@intel.com>
Change-Id: Ib80656441fd1f5d18cc93dc9560e95b6ef70bed2
Orig-Change-Id: I71c9e1becc8d82d2f058002c1fe65630848de73c
Signed-off-by: zheng.zixiang <zixiangx.zheng@intel.com>
Signed-off-by: ziyux.jiang <ziyux.jiang@intel.com>
Reviewed-on: http://android.intel.com:8080/22951
Reviewed-by: Koski, Anttu <anttu.koski@intel.com>
Reviewed-by: Cohen, David A <david.a.cohen@intel.com>
Reviewed-by: Koskinen, Ilkka <ilkka.koskinen@intel.com>
Reviewed-by: Kruger, Jozef <jozef.kruger@intel.com>
Reviewed-by: Zhang, Xiaolin <xiaolin.zhang@intel.com>
Reviewed-by: Wang, Wen W <wen.w.wang@intel.com>
Tested-by: Koski, Anttu <anttu.koski@intel.com>
Reviewed-by: buildbot <buildbot@intel.com>
Tested-by: buildbot <buildbot@intel.com>
Reviewed-on: http://android.intel.com:8080/27992
Reviewed-by: Tuominen, TeemuX <teemux.tuominen@intel.com>
drivers/media/video/atomisp/css/sh_css_binary.c

index 9cee7fd..fc8c040 100644 (file)
@@ -203,7 +203,7 @@ init_binary_info(struct sh_css_binary_info *info, bool *binary_found)
                _init_binary_info(info, ISP_VIDEO_DS_);
                break;
        default:
-               break;
+               return sh_css_err_invalid_arguments;
        }
        info->s3atbl_use_dmem = _S3ATBL_USE_DMEM(info->min_output_width !=
                                                 info->max_output_width);