spi: tegra210-quad: Don't initialise DMA if not supported
authorJon Hunter <jonathanh@nvidia.com>
Wed, 26 Oct 2022 15:56:33 +0000 (16:56 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 28 Oct 2022 16:27:44 +0000 (17:27 +0100)
The following error messages are observed on boot for Tegra234 ...

 ERR KERN tegra-qspi 3270000.spi: cannot use DMA: -19
 ERR KERN tegra-qspi 3270000.spi: falling back to PIO

Tegra234 does not support DMA for the QSPI and so initialising the DMA
is expected to fail. The above error messages are misleading for devices
that don't support DMA and so fix this by skipping the DMA
initialisation for devices that don't support DMA.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20221026155633.141792-1-jonathanh@nvidia.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra210-quad.c

index 9049726..10f0c5a 100644 (file)
@@ -720,6 +720,9 @@ static int tegra_qspi_start_cpu_based_transfer(struct tegra_qspi *qspi, struct s
 
 static void tegra_qspi_deinit_dma(struct tegra_qspi *tqspi)
 {
+       if (!tqspi->soc_data->has_dma)
+               return;
+
        if (tqspi->tx_dma_buf) {
                dma_free_coherent(tqspi->dev, tqspi->dma_buf_size,
                                  tqspi->tx_dma_buf, tqspi->tx_dma_phys);
@@ -750,6 +753,9 @@ static int tegra_qspi_init_dma(struct tegra_qspi *tqspi)
        u32 *dma_buf;
        int err;
 
+       if (!tqspi->soc_data->has_dma)
+               return 0;
+
        dma_chan = dma_request_chan(tqspi->dev, "rx");
        if (IS_ERR(dma_chan)) {
                err = PTR_ERR(dma_chan);