x86/retpoline: Fix crash printing warning
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 25 Oct 2022 15:32:49 +0000 (18:32 +0300)
committerDave Hansen <dave.hansen@linux.intel.com>
Tue, 25 Oct 2022 19:27:08 +0000 (12:27 -0700)
The first argument of WARN() is a condition, so this will use "addr"
as the format string and possibly crash.

Fixes: 3b6c1747da48 ("x86/retpoline: Add SKL retthunk retpolines")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Link: https://lore.kernel.org/all/Y1gBoUZrRK5N%2FlCB@kili/
arch/x86/kernel/alternative.c

index 19221d7..b4ac4e5 100644 (file)
@@ -418,7 +418,7 @@ clang_jcc:
                break;
 
        default:
-               WARN("%pS %px %*ph\n", addr, addr, 6, addr);
+               WARN(1, "%pS %px %*ph\n", addr, addr, 6, addr);
                return -1;
        }