net: bcmgenet: reduce severity of missing clock warnings
authorJeremy Linton <jeremy.linton@arm.com>
Mon, 24 Feb 2020 22:54:03 +0000 (16:54 -0600)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Feb 2020 23:31:23 +0000 (15:31 -0800)
If one types "failed to get enet clock" or similar into google
there are ~370k hits. The vast majority are people debugging
problems unrelated to this adapter, or bragging about their
rpi's. Further, the DT clock bindings here are optional.

Given that its not a fatal situation with common DT based
systems, lets reduce the severity so people aren't seeing failure
messages in everyday operation.

Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/genet/bcmgenet.c

index 4121567..80feb20 100644 (file)
@@ -3562,7 +3562,7 @@ static int bcmgenet_probe(struct platform_device *pdev)
 
        priv->clk = devm_clk_get(&priv->pdev->dev, "enet");
        if (IS_ERR(priv->clk)) {
-               dev_warn(&priv->pdev->dev, "failed to get enet clock\n");
+               dev_dbg(&priv->pdev->dev, "failed to get enet clock\n");
                priv->clk = NULL;
        }
 
@@ -3586,13 +3586,13 @@ static int bcmgenet_probe(struct platform_device *pdev)
 
        priv->clk_wol = devm_clk_get(&priv->pdev->dev, "enet-wol");
        if (IS_ERR(priv->clk_wol)) {
-               dev_warn(&priv->pdev->dev, "failed to get enet-wol clock\n");
+               dev_dbg(&priv->pdev->dev, "failed to get enet-wol clock\n");
                priv->clk_wol = NULL;
        }
 
        priv->clk_eee = devm_clk_get(&priv->pdev->dev, "enet-eee");
        if (IS_ERR(priv->clk_eee)) {
-               dev_warn(&priv->pdev->dev, "failed to get enet-eee clock\n");
+               dev_dbg(&priv->pdev->dev, "failed to get enet-eee clock\n");
                priv->clk_eee = NULL;
        }